Repository navigation
Introduce <RecordsIterator> - #10880
Merged
Merged
Conversation
Madeorsk
requested changes
Aug 5, 2025
Madeorsk
requested changes
Aug 5, 2025
Madeorsk
left a comment
Contributor
There was a problem hiding this comment.
A few issues related to WithListContext.
Madeorsk
requested changes
Aug 5, 2025
Madeorsk
force-pushed
the
remox-list-iterator
branch
from
August 11, 2025 10:02
280adcc to
4b20bec
Compare
fzaninotto
requested changes
Aug 12, 2025
Madeorsk
requested changes
Aug 27, 2025
Madeorsk
reviewed
Sep 5, 2025
Madeorsk
force-pushed
the
remox-list-iterator
branch
from
September 5, 2025 13:51
5c5f55a to
7a4dcbd
Compare
Madeorsk
force-pushed
the
remox-list-iterator
branch
from
September 5, 2025 15:35
35ef3cd to
77c1d8f
Compare
Madeorsk
force-pushed
the
remox-list-iterator
branch
from
September 16, 2025 14:24
4a49dca to
32d5a70
Compare
slax57
self-requested a review
September 17, 2025 07:52
slax57
requested changes
Sep 17, 2025
slax57
left a comment
Contributor
There was a problem hiding this comment.
Otherwise, incredible work! You apply changes very consistently, which makes the (otherwise painful) review process much easier, so kudos for that!
| render={record => <li>{record.title} - {record.views}</li>} | ||
| /> | ||
| </ul> | ||
| </ListBase> |
Contributor
There was a problem hiding this comment.
Don't we now have an error prop on <ListBase>? 🤔
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
Co-authored-by: Jean-Baptiste Kaiser <jb@marmelab.com>
1 task done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ListIteratorhas a drawback:empty,loadinganderrorstates appear inside the wrapper (often a<ul>). It makes it unusable in most cases.Solution
ListIteratorbyRecordsIterator, with an alias toListIterator<SimpleList>WithListContextto accept optionalempty,loading,errorandofflinecomponentsListBase/InfiniteListBase/EditBase/ShowBaseand derivated components to accept optionalauthLoading,loadinganderrorcomponents.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature